On Oct 18 12:03, Rocco Rutte wrote: > Hi, > > * Corinna Vinschen [07-10-18 10:25:56 +0200] wrote: > >> Ping? > > This patch gives me: > > muttlib.c: In function ???mutt_pretty_size???: > muttlib.c:824: warning: unknown conversion type character ???j??? in format > muttlib.c:824: warning: too many arguments for format > muttlib.c:831: warning: unknown conversion type character ???j??? in format > muttlib.c:831: warning: too many arguments for format > > with gcc 4.0.1 on OS X.
So the j specifier isn't defined on OS X. I assumed that we have a couple of systems which are not POSIXy enough to support this format specifier (and there are probably a lot which don't know intmax_t either). That's why I suggested 'll' and 'long long' as workaround. > Without looking too deeply at the issue, when off_t is used, why can't we > use LOFF_T and OFF_T_FMT as defined by configure in config.h instead? On > first sight this seems to be the right way to go. That's at least what mutt > uses for large file support. Sounds like the way to go. Sorry, I didn't realize that this is tested in configure already. Thanks, Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat