On 05/25/2007 09:18 PM, Fabian wrote:
> On 25-05-2007 21:14:48 +0200, Martin Kersten wrote:
>> Thanks! This at least indicates the direction to look for the problem.
>> Assuming you are using M5/SQL, there was a change in the 
>> src/modules/mal/mserver.mx
>> module to align with the policy of M4/SQL to test for mapi_open
>> property to access/deny connections.
>>
>> Fabian,Sjoerd could either of you check that patch
> 
> Yeah, it was faulty, and always allowing connections, ignoring the
> mapi_open property.  This has been fixed now, so it defaults to local
> connections only.  The effect of this is that you have to set mapi_open
> to true to get the previous behaviour.
> 
> 
>> --------------------------------------------
>> diff -r1.84 -r1.85
>> 604a605,606
>>>       int accept_any=1;
>>>       char *env;
>> 616a619,623
>>>       env = GDKgetenv("mapi_port");
>>>       if(env){
>>>               accept_any= (int) atol(env);
>>>       }
>>>
>> 646a654,658
>>> @-
>>> Set server port and allow network connections from any workstation.
>>> Bind the socket to the server port.
>>> @c
>>>
>> 651,652c663,666
>> <               /* FIXME: this should be configurable via the config file 
>> */
>> <               server.sin_addr.s_addr = INADDR_ANY;
>> ---
>>>               if (accept_any)
>>>                       server.sin_addr.s_addr = htonl(INADDR_ANY);
>>>               else
>>>                       server.sin_addr.s_addr = htonl(INADDR_LOOPBACK);
>> [EMAIL PROTECTED]::~/monet5/package/MonetDB5/src/modules/mal>
> 
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> MonetDB-users mailing list
> MonetDB-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/monetdb-users

It seems to me that the fix is wrong.  It looks at mapi_port, not
mapi_open to decide whether to open up the connection.

-- 
Sjoerd Mullender

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
MonetDB-users mailing list
MonetDB-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/monetdb-users

Reply via email to