Still, that's bogus for ordinary hashes... it should only care about that for objects. Though I wonder how it could possibly know the difference.
On Wed, Feb 18, 2009 at 12:17 PM, Roger Hall <[email protected]> wrote: > I had to dig around in the policy modules because it isn't actually listed > in the other document I linked. > > Specifically: ProhibitAccessOfPrivateData > > I'm only sure this is it because the error message that came out of the > report ... > > "Private Member Data shouldn't be accessed directly at line X, column Y. > Accessing an objects data directly breaks encapsulation and should be > avoided." > > ... is prominently displayed in the module. > > Thanks! > > Roger > > -----Original Message----- > From: Bill Ward [mailto:[email protected]] > Sent: Wednesday, February 18, 2009 11:11 AM > To: [email protected] > Subject: Re: ARGH! (was FW: Perl Critic and (honest) hash references) > > What was the solution? > > On Wed, Feb 18, 2009 at 8:53 AM, Roger Hall <[email protected]> wrote: > > RTFM is always pretty good advice, eh? :} > > > > -----Original Message----- > > From: Roger Hall [mailto:[email protected]] > > Sent: Wednesday, February 18, 2009 10:05 AM > > To: [email protected] > > Subject: Perl Critic and (honest) hash references > > > > $config->{query} > > > > Perlcritic complains that "Private Member Data shouldn't be accessed > > directly" because "Accessing an objects data directly breaks > encapsulation > > and should be avoided". I get that. Only problem: it's not an object. > It's > > just a hashref. > > >
