Geoffrey Young wrote:
take a look at the implementation in mp1 - why won't something like that work, so long as we're in prefork?
i.e. create a special scalar (quoting from mp1):
SV *doc_root = perl_get_sv("Apache::Server::DocumentRoot", TRUE);
sv_setsv(doc_root, ST(1));
conf->ap_document_root = SvPVX(doc_root);Joe Schaefer wrote:
> Why not add a request pool cleanup that just restores the original > pointer?
Either will work, thanks folks.
The question is whether we want to make that docroot change persistent across requests [1] or per-request[2]. Geoff's proposal matches the former [1]behavior, whereas Joe's the latter[2].
I tend to think that per-request[2] is the sane solution. That's because you can never know whether this value was already modified or not when you hit a new process. So you will always try to change it, in which case per-request[2] makes the most sense.
the only cons is that it's different from mp1 behavior, but as the above explains it makes no difference (I believe).
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
