> I was thinking, would it be better to make it an APR::Socket method? > > $socket->poll($c->pool, 1_000_000, APR::POLLIN); > > looks more intuitive to me. Especially since you've hardcoded the fd type > to be socket: > fd.desc_type = APR_POLL_SOCKET;
That's a really good idea. I'll move it into the APR::Socket interface. And thanks for the advice on how to make a patch. Regards, Ken -- Report problems: http://perl.apache.org/bugs/ Mail list info: http://perl.apache.org/maillist/modperl.html List etiquette: http://perl.apache.org/maillist/email-etiquette.html
