I was thinking, would it be better to make it an APR::Socket method?
$socket->poll($c->pool, 1_000_000, APR::POLLIN);
looks more intuitive to me. Especially since you've hardcoded the fd type to be socket:
fd.desc_type = APR_POLL_SOCKET;
That's a really good idea. I'll move it into the APR::Socket interface.
Excellent.
And thanks for the advice on how to make a patch.
There is a utility util/getdiff.pl which knows how to generate a cvs diff + diff against new files. The patch I've posted was generated with:
% util/getdiff.pl t/protocol/echo_nonblock.t \ t/protocol/TestProtocol/echo_nonblock.pm xs/APR/Poll/APR__Poll.h > patch
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
-- Report problems: http://perl.apache.org/bugs/ Mail list info: http://perl.apache.org/maillist/modperl.html List etiquette: http://perl.apache.org/maillist/email-etiquette.html
