In going through the porting document for porting
to modperl2 and following the Apache::mp3 example, there appears to be some
missing code in both http source and the pdf versions of the
document:
--- Apache/MP3.pm.4 2003-06-06
15:57:15.000000000 +1000
+++ Apache/MP3.pm 2003-06-06 16:04:48.000 @@ -1492,7 +1492,7 @@ my $suppress_auth = shift; my $r = $self->r; - my $auth_info; + my $auth_info = ''; # the check for auth_name() prevents an anno # the apache server log when authentication if ($r->auth_name && !$suppress_auth) { @@ -1509,10 +1509,9 @@ } my $vhost = $r->hostname; - unless ($vhost) { - $vhost = $r->server->server_hostname; - $vhost .= ':' . $r->get_server_port unless - } + $vhost = $r->server->server_hostname unless + $vhost .= ':' . $r->get_server_port unless $ + return "http://${auth_info}${vhost}"; } It seems that the second half of the lines is
missing (e.g. in the source for MP3.pm, "#the check for auth_name() prevents an
anno" actually expands further to be "#the check for auth_name() prevents an
annoying......"
This missing snipet hasn't affected the port up to
this point (FYI, Stas, I got it to work by starting over again), however when I
try and continue further in the tutorial I run into errors trying to remove the
Apache::compat dependency. Not sure if this is related to those errors or
not, but rather than combine multiple error reports into one email, I figured
I'd start with this problem.
Thanks Reuben Fischman
|
- Re: [mp2] Missing(?) code snipets in porting document Reuben Fischman
- Re: [mp2] Missing(?) code snipets in porting document Stas Bekman
- Re: [mp2] Missing(?) code snipets in porting docu... Reuben Fischman
- Re: [mp2] Missing(?) code snipets in porting ... Stas Bekman
- RE: [mp2] Missing(?) code snipets in port... Reuben Fischman
- Re: [mp2] Missing(?) code snipets in porting document Stas Bekman