* Dan Harnett <dan...@harnett.name> [2010-02-23 21:19]: > On Tue, Feb 23, 2010 at 02:28:17PM -0500, Dan Harnett wrote: > > On Tue, Feb 23, 2010 at 05:24:30PM +0100, Henning Brauer wrote: > > > I don't remember any changes in that area lately so this puzzles me. > > > do we know when this breakage was introduced, approximately? > > > > I have narrowed it down to between 2010/01/11 and 2010/01/12. It worked > > fine on 2010/01/11. > > > > > Probably wrong, but this fixes it.
i would not call that wrong. i don't understand how this ever worked and I don't understand what broke it. the only commit in that timeframe that could cause this is ryan's pool removal and that doesn't touch anything near that codepath. puzzled. > > Index: pf_table.c > =================================================================== > RCS file: /cvs/src/sys/net/pf_table.c,v > retrieving revision 1.82 > diff -N -u -p pf_table.c > --- pf_table.c 18 Jan 2010 23:52:46 -0000 1.82 > +++ pf_table.c 23 Feb 2010 20:09:59 -0000 > @@ -1112,6 +1112,7 @@ pfr_walktree(struct radix_node *rn, void *arg) > as.pfras_a.pfra_fback = PFR_FB_NOCOUNT; > } > splx(s); > + as.pfras_tzero = ke->u._ke._pfrke_tzero; > > if (COPYOUT(&as, w->pfrw_astats, sizeof(as), flags)) > return (EFAULT); > -- Henning Brauer, h...@bsws.de, henn...@openbsd.org BS Web Services, http://bsws.de Full-Service ISP - Secure Hosting, Mail and DNS Services Dedicated Servers, Rootservers, Application Hosting
