joel,
thanks for the comments. was looking for help when sent the initial email. On 30.01-02:45, Joel Sing wrote: [ ... ] > 1. Both of these PRs have already been resolved and closed - fix committed in > r1.70 of sys/dev/ic/elink3.c (see > http://www.openbsd.org/cgi-bin/cvsweb/src/sys/dev/ic/elink3.c). Help is > always welcome, however fixing a closed bug is kinda pointless :) never fixed it; just wanted a patch against 4.2 without having to use current. that's what the patchset is for. i also changed current to macros because it seemed wrong/bad. [ ... ] > 2. Patches and technical issues are normally directed to tech@ (assuming it's > a diff for an unresolved issue). You'll probably get more of a response than > on [EMAIL PROTECTED] thanks for the pointer. [ ... ] > 3. Patches are usually provided in a unified diff format (-u option). These > are inherently easier to read, especially when sent via email. thanks again. [ ... ] > 4. Patches should be provided against -current, not -stable. If a diff is > accepted for a serious issue it will be back ported and a patch made > available for -stable. that's what i needed and did. wasn't sure whether there was somewhere to post a patchset against stable so others could use it. is that generally done by others (i.e. unwanted) or posted elsewhere? [ ... ] > 5. If you really want to diff against -stable you can use the -rOPENBSD_4_2 > tag when running cvs. eg: aside from the '-u' that's what i did. thanks again for the pointers, much appreciated. -- t t w
