Filtered out your tips like below the code has already been fixed with lots of my code ingenuity and according to your suggestions. You see, beyond the negativity you put writing your audit we found something positive.. Be always optimistic beyond anything..
FYI, Ingo, I'm going to post my script on bsd.gaoxio.com as well. Dan ------ Blog: https://bsd.gaoxio.com - Repo: https://code.5mode.com Please reply to the mailing-list, leveraging technical stuff. Ingo Schwarze <schwa...@usta.de> wrote: > Apparently, you mean: > https://github.com/par7133/pdftexter/blob/main/pdftexter > > A few random remarks: > * If you merely want to check for the presence of a file, > use test(1) -e (or rather, the ksh(1) builtin). > No need messing around with ls(1). > Then again, you want to test whether software is installed, > which should be tested at install time of your program, > not at the run time of your program. > * "mkdir ./tmp" needs error checking: what if it exists, but > is not a directory? Just barrelling on regardless is clearly > a bad idea. Besides, i doubt the wisdom of creating a tmp > directory in the current working directory. > Use /tmp/, that's what it's for. > Look at what this command does, see mktemp(1): > mktemp -d -p /tmp/ pdftexter.XXXXXXXXXX [..] > Not trying to discourage you, just trying to help developing > a realistic self-evaluation of your current skill level. > Try practising, and have fun! > > Yours, > Ingo >
