Hello, On Wed, Jul 13, 2022 at 11:17 PM Nick Holland <n...@holland-consulting.net> wrote: > > I expected the setup to look at the / (from the ramdisk), but it > > searched in /mnt2 instead. > > As a user, I'd expect the response there to be "As would be seen > on the running system."
For an upgrade that would be a good assumption, but for an install, the running system is the installer, the target filesystem is not even existing yet. > As a user, I expect it to go something like this: > I put the install sets someplace on the running systemm, say > /home/upgrade or /usr/rel. I rebooted into bsd.rd, chose > "install" or "upgrade", I expect to answer exactly where I put > the files. How the upgrader or installer does the upgrade or > install, I really don't care." > > The installer happens to mount the system hanging off /mnt2, > but I shouldn't have to know that. I definitely shouldn't have to > include that in my answer (in my opinion) Yeah, I'm not arguing about that. I came to ask about this after reading the installer code, where comments are telling: * Accept a valid /mnt2 or /mnt relative path. * Accept a valid absolute path. Which (at least as I interpreted it) implies that you would give "home/upgrade" or "./usr/rel" for your use cases. But the second comment, and the way it is implemented, made me think the absolute pathes should work for ramdisk content. And the way the installer checks it makes '/' not search where the comment tells it should. So the modifications may just be to fix the comment and not change behavior. > > Is this in need for a modification, or is it good as-is ? > > I can submit a patch if you think it is useful. > > Speaking only for myself, I think it is working exactly as I'd > hope right now. > > I would spend some time thinking about why you are stuffing the > install files into the ramdisk rather than from an existing > file system or other more supported option. I think the "proper" > answers will work better for you all around. I am stuffing a siteXX.tgz in the ramdisk of bsd.rd, alongside the auto_install.conf file to do an automatic install on a VM. I want to avoid manual interactions with the VM, so the use of auto_install.conf, and the install.site script contained in the siteXX.tgz is for further customizations. -- Vincent Legoll
