On Tue, Oct 06, 2015 at 02:20:31AM +0300, Kimmo Paasiala wrote:
> On Mon, Oct 5, 2015 at 10:52 PM, Артур Истомин <art.is...@yandex.ru> wrote:
> > On Mon, Oct 05, 2015 at 01:07:24PM -0400, STeve Andre' wrote:
> >> The smtpd code is very good.
> >
> > static void
> > filter_tx_io(struct io *io, int evt)
> > {
> > struct filter_session *s = io->arg;
> > size_t len, n;
> > char *data;
> > char buf[65535];
> >
> >
> > switch (evt) {
> > case IO_DATAIN:
> > data = iobuf_data(&s->ibuf);
> > len = iobuf_len(&s->ibuf);
> > memmove(buf, data, len);
> > buf[len] = 0;
> >
>
> You just validated all the concerns about the quality of OpenSMTPd and
> also the need for peer/code reviews. That is not production quality
> code by any measure.
I mean exactly that. It is sarcasm about "very good code".
