On Mon, Jul 15, 2013 at 11:53:38PM +0200, Jan Stary wrote:
> > 
> > for oldrdist, "-" is actually the argument to -f. so it's not an option,
> > as far as i can see. just the manual seems to blur things by documenting
> > "If either the -f or `-' option is not specified", whereas above, the
> > text suggests "-f-" or "-f -" is how it would work.
> 
> You are right: the `-' is actually an argument to -f,
> and the manpage wording just confuses things by talking
> about "the `-' option".  BTW, it uses ".Dq" everywhere else.
> 
> Index: oldrdist.1
> ===================================================================
> RCS file: /cvs/src/usr.bin/oldrdist/oldrdist.1,v
> retrieving revision 1.20
> diff -u -p -u -p -r1.20 oldrdist.1
> --- oldrdist.1        3 Sep 2011 22:59:07 -0000       1.20
> +++ oldrdist.1        15 Jul 2013 21:38:51 -0000
> @@ -69,11 +69,9 @@ is
>  the standard input is used.
>  .El
>  .Pp
> -If either the
> -.Fl f
> -or
> -.Sq Fl
> -option is not specified, the program looks first for
> +If the
> +.Ar distfile
> +is not specified, the program looks first for
>  .Dq Pa distfile ,
>  then
>  .Dq Pa Distfile
> 

i think the previous suggestion (If the -f option is not specified) is
clearer.

> 
> 
> > similarly, look at cat(1):
> > 
> >     If file is a single dash (`-') or absent, cat reads from the
> >     standard input.
> > 
> > no mention of "-" in SYNOPSIS.
> 
> Yes; here it does not suggest that `-' is an option,
> just that it is recognized as a special value for `file'
> (which is described in SYNOPSIS).
> 
> Incidentaly, it uses
> 
>       .Pq Sq \&-
> 
> Why cannot this be just
> 
>       .Pq Sq -
> 
> ?
> 

it should be. so roll this into your diff.

> > but shutdown(8), which lists "-" in
> > SYNOPSIS:
> > 
> >     If `-' is supplied as an option, the warning message is read
> >     from standard input.
> > 
> > so, it looks like oldrdist and shutdown are just talking about "-"
> > differently to other manuals, but not behaving differently to other
> > apps. i.e. we should tweak oldrdist and shutdown too.
> 
> shutdown code actually recognizes `-' as a getopt case:
> it is technically an option, meaning "do not expect the message
> on the commandline, read it from stdin instead".
> 

ok, so we can leave shutdown alone.

jmc

Reply via email to