Looks good to me. Though i'm curious what the /boot -> boot part does. When we did it we deleted the /boot entirely.
Also while we are touching the file. Could add the M to "128" in the non efi file so it matches and is more clear. On Mon, Apr 22, 2024, 12:32 PM Denys Dmytriyenko via lists.yoctoproject.org <[email protected]> wrote: > On Sun, Apr 21, 2024 at 02:42:23PM +0530, Chirag Shilwant wrote: > > + Andreas > > On 21/04/24 08:37, Denys Dmytriyenko wrote: > > >On Sat, Apr 20, 2024 at 06:23:18PM +0530, Chirag Shilwant wrote: > > >>- Ideally running `ls /boot/` in filesystem should list contents from > /rootfs/boot partition > > >>but currently it lists the contents of /boot partition of the WIC > Image. > > >> > > >>Eg - Incase of AM64x, > > >>``` > > >> root@am64xx-evm:~# ls /boot/ > > >> EFI Image tiboot3-am64x-gp-evm.bin > tiboot3-am64x_sr2-hs-evm.bin tiboot3-am64x_sr2-hs-fs-evm.bin tiboot3.bin > tispl.bin u-boot.img uEnv.txt > > >Will this change affect EFI? As there's EFI directory in that partition. > > > > The EFI partition under /rootfs/boot will still be present. > > Following is the output of `ls /boot` with this patch, > > > > ``` > > root@am64xx-evm:~# ls /boot > > EFI Image Image-6.1.80-ti-g2e423244f8c0 dtb fitImage > > fitImage-6.1.80-ti-g2e423244f8c0 > > > > ``` > > Thanks, I'll do some additional testing with EFI a bit later. > > > > >>- To fix this issue, add --no-fstab-update flag to > WIC_CREATE_EXTRA_ARG in arago-image.inc > > >>to prevent WIC image from adding an additional entry in /etc/fstab. > > >This flag is global and will prevent all other partitions from > populating > > >/etc/fstab properly. Sure, meta-ti only has /boot and / defined, but > other > > >layers could have own wic files with e.g. /home or /data partitions. > Mounting > > >those will require a custom /etc/fstab instead of wic creating > corresponding > > >entries automatically. > > > > > > > > > Apparently, this change was being carried in processor sdk layer from > > quite a long time (from dunfell) to resolve a customer issue > > reported by Andreas. > > Diving into our internal JIRA system showed that this fix was > > suggested by Andreas > > & was resolved by the SDK team back then by keeping this change in > > processor sdk layer [1]. > > Not sure why this was in processor sdk layer though. Maybe Andreas > > can provide additional details. > > I tested and submitted a different fix last night to adjust WIC templates > to > not mount boot partition under /boot directory[1]. I still believe doing > it > just for that one partition is better than disabling fstab updates > globally. > > [1] > https://patchwork.yoctoproject.org/project/ti/patch/[email protected]/ > > Can you please take a look and maybe test this option for your use case? > Thanks. > > -- > Denys > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#15303): https://lists.yoctoproject.org/g/meta-arago/message/15303 Mute This Topic: https://lists.yoctoproject.org/mt/105635090/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-arago/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
