+ Andreas
On 21/04/24 08:37, Denys Dmytriyenko wrote:
On Sat, Apr 20, 2024 at 06:23:18PM +0530, Chirag Shilwant wrote:
- Ideally running `ls /boot/` in filesystem should list contents from 
/rootfs/boot partition
but currently it lists the contents of /boot partition of the WIC Image.

Eg - Incase of AM64x,
```
     root@am64xx-evm:~# ls /boot/
     EFI  Image  tiboot3-am64x-gp-evm.bin  tiboot3-am64x_sr2-hs-evm.bin  
tiboot3-am64x_sr2-hs-fs-evm.bin  tiboot3.bin  tispl.bin  u-boot.img  uEnv.txt
Will this change affect EFI? As there's EFI directory in that partition.

The EFI partition under /rootfs/boot will still be present.
Following is the output of `ls /boot` with this patch,

```
root@am64xx-evm:~# ls /boot
EFI  Image  Image-6.1.80-ti-g2e423244f8c0 dtb  fitImage  fitImage-6.1.80-ti-g2e423244f8c0

```




```

- To fix this issue, add --no-fstab-update flag to WIC_CREATE_EXTRA_ARG in 
arago-image.inc
to prevent WIC image from adding an additional entry in /etc/fstab.
This flag is global and will prevent all other partitions from populating
/etc/fstab properly. Sure, meta-ti only has /boot and / defined, but other
layers could have own wic files with e.g. /home or /data partitions. Mounting
those will require a custom /etc/fstab instead of wic creating corresponding
entries automatically.



Apparently, this change was being carried in processor sdk layer from
quite a long time (from dunfell) to resolve a customer issue reported by Andreas. Diving into our internal JIRA system showed that this fix was suggested by Andreas & was resolved by the SDK team back then by keeping this change in processor sdk layer [1]. Not sure why this was in processor sdk layer though. Maybe Andreas can provide additional details.

Btw, I also see other SOC vendors (meta-freescale) adding --no-fstab-update flag to WIC_CREATE_EXTRA_ARG [2] So, if we are planning to pull in this change should it go somewhere in meta-ti (maybe k3.inc [3])?

[1]: https://git.ti.com/cgit/processor-sdk/meta-processor-sdk/commit/recipes-core/images/tisdk-default-image.bbappend?h=dunfell&id=58975a30e8f90efbffb97e49d5baac02971644da [2]: https://git.yoctoproject.org/meta-freescale/tree/conf/machine/include/imx-base.inc?h=scarthgap#n614 [3]: https://git.ti.com/cgit/arago-project/meta-ti/tree/meta-ti-bsp/conf/machine/include/k3.inc?h=scarthgap


Signed-off-by: Chirag Shilwant <[email protected]>
---
  meta-arago-distro/recipes-core/images/arago-image.inc | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/meta-arago-distro/recipes-core/images/arago-image.inc 
b/meta-arago-distro/recipes-core/images/arago-image.inc
index 00308b57..2a34a709 100644
--- a/meta-arago-distro/recipes-core/images/arago-image.inc
+++ b/meta-arago-distro/recipes-core/images/arago-image.inc
@@ -31,4 +31,6 @@ BAD_RECOMMENDATIONS += " \
  "
  BAD_RECOMMENDATIONS += "${@oe.utils.conditional("INIT_MANAGER", "sysvinit", "", 
"busybox-syslog", d)}"
+WIC_CREATE_EXTRA_ARGS += " --no-fstab-update"
+
  inherit core-image remove-net-rules
--
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#15300): 
https://lists.yoctoproject.org/g/meta-arago/message/15300
Mute This Topic: https://lists.yoctoproject.org/mt/105635090/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-arago/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to