On 10/31/2023 10:44 AM, Denys Dmytriyenko wrote:
On Tue, Oct 31, 2023 at 09:04:32AM -0500, Ryan Eatmon via
lists.yoctoproject.org wrote:
We want to add an image into the core bundle, but that image does not
have any opkg .control files. tar apparently errors out if you ask it
to extract out files but the files are not in the archive, and the
recipes are setup that if any of the commands in the shell error out,
then the entire recipe fails.
Simple fix, add an || (or) condition to the tar command to print a
message that there were not any control files instead of erroring out.
So, simply bypassing tar error due to missing *.control files still won't
enable you to properly generate the SW manifest. As those *.control files
from individual packages are parsed to extract the license information.
And they are missing because tiny image specifically disables "package
management" to save on space. Therefore tiny image was not included in
the bundle, since it doesn't generate the SW manifest.
And this is why I sent the patch in rather than just taking it. This
patch was a response to Chirag running in the above error when trying to
add the tiny image into the core bundle in the processor sdk.
So, why do we want to add tiny to the bundle? Since tiny should be a
subset of the other images, is there anything not covered in the
software manifest that should prevent this patch?
Signed-off-by: Ryan Eatmon <[email protected]>
---
meta-arago-distro/classes/tisdk-sw-manifest.bbclass | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta-arago-distro/classes/tisdk-sw-manifest.bbclass
b/meta-arago-distro/classes/tisdk-sw-manifest.bbclass
index 14d14f08..b9c63610 100644
--- a/meta-arago-distro/classes/tisdk-sw-manifest.bbclass
+++ b/meta-arago-distro/classes/tisdk-sw-manifest.bbclass
@@ -405,10 +405,10 @@ sw_manifest_target() {
# Only extract tar.gz or tar.bz2 types
if [ -e ${IMAGE_ROOTFS}/filesystem/${image}-${MACHINE}.tar.xz ]
then
- tar xJf ${IMAGE_ROOTFS}/filesystem/${image}-${MACHINE}.tar.xz -C
${IMAGE_ROOTFS}/filesystem --wildcards *.control
+ tar xJf ${IMAGE_ROOTFS}/filesystem/${image}-${MACHINE}.tar.xz -C
${IMAGE_ROOTFS}/filesystem --wildcards *.control || echo "No control files found in
${image}"
elif [ -e ${IMAGE_ROOTFS}/filesystem/${image}-${MACHINE}.tar.gz ]
then
- tar xzf ${IMAGE_ROOTFS}/filesystem/${image}-${MACHINE}.tar.gz -C
${IMAGE_ROOTFS}/filesystem --wildcards *.control
+ tar xzf ${IMAGE_ROOTFS}/filesystem/${image}-${MACHINE}.tar.gz -C
${IMAGE_ROOTFS}/filesystem --wildcards *.control || echo "No control files found in
${image}"
fi
done
--
2.17.1
--
Ryan Eatmon [email protected]
-----------------------------------------
Texas Instruments, Inc. - LCPD - MGTS
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#14980):
https://lists.yoctoproject.org/g/meta-arago/message/14980
Mute This Topic: https://lists.yoctoproject.org/mt/102297493/21656
Group Owner: [email protected]
Unsubscribe:
https://lists.yoctoproject.org/g/meta-arago/leave/10763299/21656/89520264/xyzzy
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
