On Wednesday, November 18, 2015 09:44:34 AM Ian Romanick wrote: > From: Ian Romanick <ian.d.roman...@intel.com> > > Apparently, this has been a bug since 2010 (c30f6e5d). > > Also use ARRAY_SIZE instead of open coding it. > > Signed-off-by: Ian Romanick <ian.d.roman...@intel.com> > Cc: Kenneth Graunke <kenn...@whitecape.org> > Cc: mesa-sta...@lists.freedesktop.org > --- > src/glsl/ir.cpp | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp > index 8b5ba71..80cbdbf 100644 > --- a/src/glsl/ir.cpp > +++ b/src/glsl/ir.cpp > @@ -1425,8 +1425,7 @@ static const char * const tex_opcode_strs[] = { "tex", > "txb", "txl", "txd", "txf > > const char *ir_texture::opcode_string() > { > - assert((unsigned int) op <= > - sizeof(tex_opcode_strs) / sizeof(tex_opcode_strs[0])); > + assert((unsigned int) op < ARRAY_SIZE(tex_opcode_strs)); > return tex_opcode_strs[op]; > } > >
Good catch! Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev