On Wed, Nov 4, 2015 at 11:05 AM, Michel Dänzer <mic...@daenzer.net> wrote: > From: Michel Dänzer <michel.daen...@amd.com> > > Fixes GPUVM conflicts with non-4K page size. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92738 > > v2: Replace sanitization of VM base address alignment with comment why > that's not necessary. > > Cc: mesa-sta...@lists.freedesktop.org > Signed-off-by: Michel Dänzer <michel.daen...@amd.com> > Reviewed-by: Christian König <christian.koe...@amd.com> (v1) > --- > > Christian, does this address your concern? I think making the alignment > larger than necessary would be confusing as well. > > src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 30 > +++++++++++++++++---------- > 1 file changed, 19 insertions(+), 11 deletions(-) > > diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_bo.c > b/src/gallium/winsys/radeon/drm/radeon_drm_bo.c > index 2878c8f..2c36db3 100644 > --- a/src/gallium/winsys/radeon/drm/radeon_drm_bo.c > +++ b/src/gallium/winsys/radeon/drm/radeon_drm_bo.c > @@ -76,6 +76,9 @@ struct radeon_bomgr { > bool va; > uint64_t va_offset; > struct list_head va_holes; > + > + /* BO size alignment */ > + long size_align;
Any reason to use "long"? It's not like this will ever be greater than 2^32. "unsigned" should be enough. Other than that: Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
