On Tue, Jul 07, 2015 at 08:40:12PM +0100, Emil Velikov wrote: > On 06/07/15 11:33, Chris Wilson wrote: > > Since there was an ABI break and linking twice against libudev.so.0 and > > libudev.so.1 causes the application to quickly crash, we first check if > > the application is currently linked against libudev before dlopening a > > local handle. However for backwards/forwards compatability, we need to > > inspect the application for current linkage against all known versions > > first. > > > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > I'm ever so slightly conserned that RTLD_NOLOAD is not part of the POSIX > standard, thus it's missing on some platforms (*BSD seems ok, while > Solaris, MacOS are not). > > Then again this code is not build for them so we are safe. Plus it does > save nastry crashes :-) Feel free to add the Cc: mesa-stable tag. > > Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com>
Included your addendum as a reference for the future and pushed, To ssh://git.freedesktop.org/git/mesa/mesa c8d3eba..f241345 f2413457937f8f4a92e11379569be69e508d7477 -> maste Thanks for the review. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
