On Jun 16, 2015 11:15, "Anuj Phogat" <anuj.pho...@gmail.com> wrote: > > Without this patch, piglit test fbo_integer_readpixels_sint_uint fails, when > forced to use the meta pbo path. > > Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> > Cc: <mesa-sta...@lists.freedesktop.org> > --- > src/mesa/drivers/common/meta_tex_subimage.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mesa/drivers/common/meta_tex_subimage.c b/src/mesa/drivers/common/meta_tex_subimage.c > index 00364f8..84cbc50 100644 > --- a/src/mesa/drivers/common/meta_tex_subimage.c > +++ b/src/mesa/drivers/common/meta_tex_subimage.c > @@ -283,6 +283,9 @@ _mesa_meta_pbo_GetTexSubImage(struct gl_context *ctx, GLuint dims, > > if (_mesa_need_rgb_to_luminance_conversion(rb->Format, format)) > return false; > + > + if (_mesa_need_signed_unsigned_int_conversion(rb->Format, format, type)) > + return false;
Hrm... This seems fishy. Isn't glBlitFramebuffers supposed to handle format conversion with integers? If so we should probably fix it rather than just skip it for the meta pbo path. > } > > /* For arrays, use a tall (height * depth) 2D texture but taking into > -- > 1.9.3 > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
