https://bugs.freedesktop.org/show_bug.cgi?id=90207
José Fonseca <jfons...@vmware.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #17 from José Fonseca <jfons...@vmware.com> ---
(In reply to Tapani Pälli from comment #16)
> Yep it is correct, just like with _mesa_longest_attribute_name_length.
Thanks. I pushed the fix now.
> Not sure why I did not manage to hit this.
It's random -- I think that is_active_attrib ends up interpreting random
pointer addresses as enums and decide on them. Maybe the randomness is higher
with gallium drivers.
It was only when I try to print var->name that things started to crash
consistently for me.
> > I think we should invest the time to make RESOURCE_VAR and friends more
> > robust, by adding assertions that the types are indeed correct. (Replace
> > DECL_RESOURCE_FUNC helper macro by manually written code if necessary.)
> >
> > This sort of bugs is hard to find otherwise.
>
> I agree, current way is too fragile. IMO a type template would be best
> solution. Maybe first just adding the assert for the correct type is good
> start.
Yep.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
