On Fri, Apr 10, 2015 at 12:52 PM, Ben Widawsky <benjamin.widaw...@intel.com> wrote: > When an instruction has a side effect, it impacts the available options when > reordering an instruction. As the EOT flag is an implied write to the render > target in the FS, it can be considered a side effect. > > This patch shouldn't actually have any impact on the current code since the > EOT > flag implies that the opcode is already one with side effects, > FS_OPCODE_FB_WRITE. The next patch however will introduce an optimization > whereby the EOT flag can occur with an opcode SHADER_OPCODE_TEX, and as that > instruction will perform the same implied write to the render target, it > cannot > be reordered. > > Cc: Matt Turner <matts...@gmail.com> > Signed-off-by: Ben Widawsky <b...@bwidawsk.net> > Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 7 +++++++ > src/mesa/drivers/dri/i965/brw_ir_fs.h | 1 + > 2 files changed, 8 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > b/src/mesa/drivers/dri/i965/brw_fs.cpp > index 1f8febc..214ba40 100644 > --- a/src/mesa/drivers/dri/i965/brw_fs.cpp > +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp > @@ -531,6 +531,13 @@ fs_inst::can_do_source_mods(struct brw_context *brw) > return true; > } > > +
Like I mentioned before, remove this extra new line. With that this patch is Reviewed-by: Matt Turner <matts...@gmail.com> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
