On Mon, Dec 1, 2014 at 5:04 AM, Eduardo Lima Mitev <el...@igalia.com> wrote: > In OpenGL and OpenGL-Es 3+, GL_DEPTH_STENCIL_ATTACHMENT is a valid attachment > point for the family of functions > that invalidate a framebuffer object (e.g, glInvalidateFramebuffer, > glInvalidateSubFramebuffer, etc). > Currently, a GL_INVALID_ENUM error is emitted for this attachment point. > > Fixes 21 dEQP test failures under 'dEQP-GLES3.functional.fbo.invalidate.*'. > --- > src/mesa/main/fbobject.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c > index 8283373..19c4020 100644 > --- a/src/mesa/main/fbobject.c > +++ b/src/mesa/main/fbobject.c > @@ -3073,6 +3073,10 @@ invalidate_framebuffer_storage(GLenum target, GLsizei > numAttachments, > case GL_DEPTH_ATTACHMENT: > case GL_STENCIL_ATTACHMENT: > break; > + case GL_DEPTH_STENCIL_ATTACHMENT: > + if (_mesa_is_desktop_gl(ctx) || _mesa_is_gles3(ctx)) > + break; > + /* otherwise fall through */
I'd change the comment to just '/* fallthrough */' to match other occurrences. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
