Hi, On Tuesday, October 28, 2014 19:43:23 Neil Roberts wrote: > I think if you change the clip depth mode without changing the clip > origin then only the _NEW_VIEWPORT state would be set. Does that mean we > have to add _NEW_VIEWPORT to the state for the gen7_clip_state atom as > well to make sure that upload_clip_state is called? As of what is checked in today, yes. Nevertheless, Marek had an idea for a followup patch to avoid this new _NEW_VIEWPORT dependency of st_atom_rasterizer in the gallium state tracker by flagging _NEW_TRANSFORM from glClipControl. To me this sounds plausible and better matches the documentation of _NEW_TRANSFORM in mtypes.h as clip control modes is part of gl_context::Transform. Also gen6_clip_state.c:upload_clip_state already depends on _NEW_TRANSFORM and would not need a new dependency then. The patch for this was sent to the list somewhere at the weekend.
Greetings Mathias _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
