On Wed, Sep 24, 2014 at 3:57 PM, Dave Airlie <airl...@gmail.com> wrote:
> On 25 September 2014 08:51, Ian Romanick <i...@freedesktop.org> wrote:
>> On 09/24/2014 12:52 PM, Eric Anholt wrote:
>>> Roland Scheidegger <srol...@vmware.com> writes:
>>>
>>>> Oh yes and missing ALIGN + MAX2 too. I guess we could easily move these
>>>> to util code. That plus the things I already mentioned should be all
>>>> needed I think. But I strongly believe either this needs to be done or
>>>> we should revert it.
>>>
>>> What's the actual problem being caused, though, other than needing to
>>> add an include dir? I mean, the previous state was that drivers were
>>> compiling a second copy of the file themselves inside of gallium, and
>>> being careful to make all our link targets link it exactly once, which
>>> seems definitely worse than "oh, yeah, something outside of mesa/
>>> includes some mesa/ static inlines and #define helpers".
>>>
>>> If someone was really offended by this, you could move bitset to util/,
>>> and evict ffs code to the single caller in nouveau (which is probably a
>>> good idea, because using ffs in your loop is probably a terrible idea
>>> anyway). But I think we all have more important things to be doing, and
>>> I don't think there's any actual harm being done.
>>
>> Yeah... these sound like great janitor projects for new community
>> developers... not so much for people with deadlines and deliverables.
>>
>
> Hey less snark, thats my job,
>
> but really these are good jobs for people with deadlines and
> deliverables to do before they go moving code around, we haven't had
> util for 5 years, why the push to mess it up already, if the code
> isn't ready to move yet cleanly, don't move it.
>
> personally I'd rather we revert this until util can grow the required bits.
We could have fixed it by now. Here's a branch to start things:
git://people.freedesktop.org/~mattst88/mesa util
We should work on getting rid of
src/mesa/main/{imports,macros,compiler}* and moving useful bits to
util/
Does anyone else want to do this, or do I just need to?
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
