Roland Scheidegger <srol...@vmware.com> writes: > Oh yes and missing ALIGN + MAX2 too. I guess we could easily move these > to util code. That plus the things I already mentioned should be all > needed I think. But I strongly believe either this needs to be done or > we should revert it.
What's the actual problem being caused, though, other than needing to add an include dir? I mean, the previous state was that drivers were compiling a second copy of the file themselves inside of gallium, and being careful to make all our link targets link it exactly once, which seems definitely worse than "oh, yeah, something outside of mesa/ includes some mesa/ static inlines and #define helpers". If someone was really offended by this, you could move bitset to util/, and evict ffs code to the single caller in nouveau (which is probably a good idea, because using ffs in your loop is probably a terrible idea anyway). But I think we all have more important things to be doing, and I don't think there's any actual harm being done.
pgpRIqsu3Y6Cu.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
