On vie, 2014-09-19 at 00:26 -0700, Jordan Justen wrote: > On Thu, Sep 18, 2014 at 11:50 PM, Samuel Iglesias Gonsálvez > <sigles...@igalia.com> wrote: > > On Thu, 2014-09-18 at 16:05 -0700, Jordan Justen wrote: > >> On Thu, Aug 14, 2014 at 4:12 AM, Iago Toral Quiroga <ito...@igalia.com> > >> wrote: > >> > From: Samuel Iglesias Gonsalvez <sigles...@igalia.com> > >> > > >> > + this->xfb_output = src_reg(this, > >> > + glsl_type::uint_type, > >> > + linked_xfb_info->NumOutputs * > >> > + c->gp->program.VerticesOut); > >> > + this->xfb_output_offset = src_reg(this, glsl_type::uint_type); > >> > + emit(MOV(dst_reg(this->xfb_output_offset), src_reg(0u))); > >> > + /* Create a virtual register to hold destination indices in SOL */ > >> > + this->destination_indices = src_reg(this, glsl_type::uvec4_type); > >> > + /* Create a virtual register to hold temporal values in SOL */ > >> > + this->sol_temp = src_reg(this, glsl_type::uvec4_type); > >> > >> What is the duration of liveness for sol_temp? > >> > >> Would it be better to generate a new temp in each function to help out > >> register allocation? > >> > > > > Yes, it is better. I have made this change: create a new temp virtual > > register in every place it is needed (emit_thread_end(), xfb_write(), > > xfb_program()). > > Cool. Add Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> for > this patch, and: > i965/gen6/gs: Avoid buffering transform feedback varyings twice. > i965/gen6/gs: Fix binding table clash between TF surfaces and textures. > i965/gen6/gs: Enable transform feedback support in geometry shaders > i965/gen6/gs: upload ubo and pull constants surfaces. > i965/gen6/gs: Use a specific implementation of geometry shaders for gen6. > i965/gen6: enable GLSL 1.50 and OpenGL 3.2 > > That is the rest of the series, right?
Yes. > Thank you both for all the great work on this series! Great, thanks for taking the time to review all the patches! I'll push them later today. Iago _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
