On Tue, Jul 1, 2014 at 11:06 AM, Neil Roberts <n...@linux.intel.com> wrote:
> Jason Ekstrand <ja...@jlekstrand.net> writes:
>
> >> +static void
> >> +clear_image_to_zero(GLubyte *dstMap, GLint dstRowStride,
> >> + GLsizei width, GLsizei height,
> >> + GLsizei clearValueSize)
> >> +{
> >> + while (height-- > 0) {
> >> + memset(dstMap, 0, clearValueSize * width);
> >> + dstMap += dstRowStride;
> >> + }
> >> +}
> >>
> >
> > Technically, this should always work, but you might want to throw in a
> > comment about floating-point textures.
>
> I'm not sure what you mean here. Are you saying that hypothetically
> floating-point textures might not represent 0 as zero bytes?
>
sorry, I got nervous about memsetting floats. It isn't actually a problem
though since floating-point zero is just all zeroes. It doesn't really
matter much.
>
> > Other than that, looks good to me. (I'll second Ilia's MS comment
> > though.)
>
> Does that count as ‘reviewed-by’? (Yes, in the github branch I've made
> the two changes that Ilia suggested.)
>
Sure.
Reviewed-by: Jason Ekstrand <jason.ekstr...@intel.com>
>
> Thanks for the review.
>
> - Neil
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
