On 04/30/2014 12:41 PM, Eric Anholt wrote: > Ian Romanick <i...@freedesktop.org> writes: > >> A lot the patches in this series were slightly reworked to incorporate >> Eric's feedback (remove ir_variable::user_location) on the previous >> attempt. Other than that change, I patch 1 is new, and patch 16 adds >> previously missing display list support. > > Patch 2, 3, 13, 16, 17, 18, 20, 21 are: > > Reviewed-by: Eric Anholt <e...@anholt.net> > > I think my patch 15 comments were minor, and if you agree with them > (meaning I actually understood what was going on), then apply the r-b > there too. > > Patch 19 is: > > Acked-by: Eric Anholt <e...@anholt.net> > > Patch 14 I don't think is needed (since we've got explicit locations > being assigned to corresponding varying slots).
The sorting is so that a vertex shader that does
out vec4 a;
out vec4 b;
and a fragment shader that does
in vec4 b;
in vec4 a;
will assign the same locations for a and b. If both shaders have the
same set of varyings, they'll all get the same locations. Without
sorting, we assign the locations based on the order in which variables
appear in the shader text.
signature.asc
Description: OpenPGP digital signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
