On Thu, Apr 3, 2014 at 10:07 AM, Brian Paul <bri...@vmware.com> wrote: > On 04/02/2014 11:17 PM, Thomas Hellstrom wrote: >> >> On 04/01/2014 05:04 PM, Rob Clark wrote: >>> >>> From: Rob Clark <robcl...@freedesktop.org> >>> >>> Add support to property handle solid-fill src and/or mask. Without this >>> we fallback to sw a lot for common things like text rendering. >>> >>> Signed-off-by: Rob Clark <robcl...@freedesktop.org> >>> --- >>> src/gallium/state_trackers/xa/xa_composite.c | 88 ++++---- >>> src/gallium/state_trackers/xa/xa_priv.h | 7 +- >>> src/gallium/state_trackers/xa/xa_renderer.c | 289 >>> ++++++++++++++++----------- >>> src/gallium/state_trackers/xa/xa_tgsi.c | 31 ++- >>> 4 files changed, 242 insertions(+), 173 deletions(-) >> >> >> Rob, >> While testing this patch it looks like we sometimes set two samplers, >> and the first one is NULL. >> The SVGA driver asserts on that condition. >> We might need to move the active sampler to the first entry in that >> case, and adjust tex coords and shader accordingly. >> >> I'll discuss with BrianP. > > > I think the root problem is a disagreement between texture samplers and > sampler views. If a texture sampler is non-null, the corresponding sampler > view be should be non-null too, and vice versa. > > We're tripping over an assertion when a a sampler view is non-null but the > corresponding sampler is NULL.
Right.. Well, I think it would be not to hard to make things always start with SAMP[0], which would avoid this. But I am pretty fuzzy about whether it is the driver or state tracker that is wrong here.. I started with the assumption that it was just a freedreno bug, but if it causes problem w/ vmware too, then maybe the state tracker is at fault. BR, -R > I'm going to write a patch for the driver to be more resilient in that > situation. > > -Brian > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
