On 02/14/2014 03:00 PM, Eric Anholt wrote: > Compare this VS to the one for the post-130 case. Fixes piglit > glsl-lod-bias, and presumably tons of other code (I haven't done a full > piglit run on swrast).
Looks like a good fix. If we had NV_explicit_attrib_location[1], we could easily unify a bunch of the vertex shaders in meta because it enables "in" and "out" generally. :( 1: http://www.khronos.org/registry/gles/extensions/NV/NV_explicit_attrib_location.txt > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74911 Reviewed-by: Ian Romanick <ian.d.roman...@intel.com> > --- > src/mesa/drivers/common/meta.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c > index d3ca3b7..dd905dd 100644 > --- a/src/mesa/drivers/common/meta.c > +++ b/src/mesa/drivers/common/meta.c > @@ -193,7 +193,7 @@ _mesa_meta_setup_blit_shader(struct gl_context *ctx, > || ctx->Const.GLSLVersion < 130) { > vs_source = > "attribute vec2 position;\n" > - "attribute vec3 textureCoords;\n" > + "attribute vec4 textureCoords;\n" > "varying vec4 texCoords;\n" > "void main()\n" > "{\n" > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
