On 01/25/2014 05:00 PM, Chris Forbes wrote: > On Thu, Jan 23, 2014 at 6:58 AM, Courtney Goeltzenleuchter > <court...@lunarg.com> wrote: >> On Tue, Jan 21, 2014 at 3:34 AM, Chris Forbes <chr...@ijw.co.nz> wrote: >>> >>> We're about to need this in another place. >>> >>> Signed-off-by: Chris Forbes <chr...@ijw.co.nz> >>> --- >>> src/mesa/drivers/dri/i965/intel_fbo.c | 7 +++++-- >>> 1 file changed, 5 insertions(+), 2 deletions(-) >>> >>> diff --git a/src/mesa/drivers/dri/i965/intel_fbo.c >>> b/src/mesa/drivers/dri/i965/intel_fbo.c >>> index 4cdf54d..e7c5571 100644 >>> --- a/src/mesa/drivers/dri/i965/intel_fbo.c >>> +++ b/src/mesa/drivers/dri/i965/intel_fbo.c >>> @@ -433,16 +433,19 @@ intel_renderbuffer_update_wrapper(struct >>> brw_context *brw, >>> intel_miptree_check_level_layer(mt, level, layer); >>> irb->mt_level = level; >>> >>> + int layer_multiplier; >>> >> Shouldn't this declaration be at the top of the function? > > Since we're not restricted to C89 in the driver, I put it as close to > the point of use as possible -- but yes, I can move it to the top of > the function if you think that's clearer.
FWIW, I prefer putting declarations closer to their use...I'd stick with the way you did it. C99 is fine in the driver, since nobody uses MSVC on it. --Ken
signature.asc
Description: OpenPGP digital signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
