On Mon, Jan 20, 2014 at 07:58:08PM -0800, Paul Berry wrote: > On 20 December 2013 06:39, Topi Pohjolainen <topi.pohjolai...@intel.com> > wrote: > > Unit tests comparing generated blorp programs to known good need > to have the dump in designated file instead of in default > standard output. The comparison also expects the jump counters > of if-else-instructions to be correctly set and hence the dump > needs to be taken _after_ 'patch_IF_ELSE()' is run (the default > dump of the fs_generator does this before). > > Signed-off-by: Topi Pohjolainen <topi.pohjolai...@intel.com> > --- > src/mesa/drivers/dri/i965/brw_fs.h | 7 +++++-- > src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 15 +++++++++------ > 2 files changed, 14 insertions(+), 8 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.h > b/src/mesa/drivers/dri/i965/brw_fs.h > index 9bef07c..d40d0a8 100644 > --- a/src/mesa/drivers/dri/i965/brw_fs.h > +++ b/src/mesa/drivers/dri/i965/brw_fs.h > @@ -510,10 +510,13 @@ public: > > const unsigned *generate_assembly(exec_list *simd8_instructions, > exec_list *simd16_instructions, > - unsigned *assembly_size); > + unsigned *assembly_size, > + bool dump_enabled = false, > + FILE *dump_file = stdout); > > Nit pick: rather than add 2 args, wouldn't it be easier to just add the > dump_file arg, with a default value of NULL, and only dump instructions if > it is non-NULL?
I'll change that, I actually had what you suggest originally :) > > Either way, the patch is: > > Reviewed-by: Paul Berry <stereotype...@gmail.com> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
