On 11 December 2013 13:59, Paul Berry <stereotype...@gmail.com> wrote:
> On 26 November 2013 00:08, Francisco Jerez <curroje...@riseup.net> wrote: > >> --- >> src/mesa/main/uniform_query.cpp | 36 ++++++++++++++++++++++++++++++++++++ >> 1 file changed, 36 insertions(+) >> >> diff --git a/src/mesa/main/uniform_query.cpp >> b/src/mesa/main/uniform_query.cpp >> index 88ad476..fec45be 100644 >> --- a/src/mesa/main/uniform_query.cpp >> +++ b/src/mesa/main/uniform_query.cpp >> @@ -686,6 +686,9 @@ _mesa_uniform(struct gl_context *ctx, struct >> gl_shader_program *shProg, >> case GLSL_TYPE_SAMPLER: >> match = (basicType == GLSL_TYPE_INT); >> break; >> + case GLSL_TYPE_IMAGE: >> + match = (type == GL_INT); >> + break; >> > > Why do samplers use basicType == GLSL_TYPE_INT and images use type == > GL_INT? There should be a comment explaining this difference. > > With that fixed, this patch is: > > Reviewed-by: Paul Berry <stereotype...@gmail.com> > I sent comments on patches 2, 3, 4, 5, 6, 8, 9, 15, 18, 19, 20, and 23. All of those comments were minor except for my comments on patch 19. The rest of the series is: Reviewed-by: Paul Berry <stereotype...@gmail.com>
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
