On 10/14/2013 10:12 AM, Anuj Phogat wrote: > Patches listed below implement the GL_ARB_sample_shading extension > on Intel hardware >= gen6. I verified the implementation with a > number of piglit tests, currently under review on piglit mailing > list. Observed no piglit, gles3 CTS regressions with these patches > on SNB & IVB. > These patches can also be found at my github branch: > https://github.com/aphogat/mesa.git branch: sample-shading-5 > > Anuj Phogat (8): > mesa: Add infrastructure for GL_ARB_sample_shading
With Matt's comment resolved, patch 1 is: Reviewed-by: Ian Romanick <ian.d.roman...@intel.com> > mesa: Add new functions and enums required by GL_ARB_sample_shading Matt and I sent out a bunch of comments about patch 2. Since there are so many comments, I'd like to see the updated patch before committing. > mesa: Pass number of samples as a program state variable I sent out comments for patch 3. Assuming those are resolved, this patch is also Reviewed-by. > glsl: Add new builtins required by GL_ARB_sample_shading I sent out comments for patch 4. Assuming those are resolved (including the new piglit test), this patch is also Reviewed-by. > i965: Implement FS backend for ARB_sample_shading > i965/gen6: Enable the features required for GL_ARB_sample_shading > i965/gen7: Enable the features required for GL_ARB_sample_shading > i965: Enable ARB_sample_shading on intel hardware >= gen6 I'll leave review of the back-end stuff to Ken, Paul, or Eric. > src/glsl/builtin_variables.cpp | 11 +++ > src/glsl/glcpp/glcpp-parse.y | 3 + > src/glsl/glsl_parser_extras.cpp | 1 + > src/glsl/glsl_parser_extras.h | 2 + > src/glsl/link_varyings.cpp | 2 + > src/glsl/standalone_scaffolding.cpp | 1 + > src/mapi/glapi/gen/ARB_sample_shading.xml | 19 +++++ > src/mapi/glapi/gen/GL3x.xml | 5 ++ > src/mapi/glapi/gen/gl_API.xml | 2 +- > src/mesa/drivers/dri/i965/brw_fs.cpp | 109 > +++++++++++++++++++++++++++ > src/mesa/drivers/dri/i965/brw_fs.h | 4 + > src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 23 ++++++ > src/mesa/drivers/dri/i965/brw_wm.h | 1 + > src/mesa/drivers/dri/i965/gen6_wm_state.c | 67 +++++++++++++++- > src/mesa/drivers/dri/i965/gen7_wm_state.c | 70 ++++++++++++++++- > src/mesa/drivers/dri/i965/intel_extensions.c | 1 + > src/mesa/main/enable.c | 16 ++++ > src/mesa/main/extensions.c | 1 + > src/mesa/main/get.c | 4 + > src/mesa/main/get_hash_params.py | 3 + > src/mesa/main/mtypes.h | 10 ++- > src/mesa/main/multisample.c | 13 ++++ > src/mesa/main/multisample.h | 2 + > src/mesa/main/tests/dispatch_sanity.cpp | 4 +- > src/mesa/program/prog_print.c | 5 ++ > src/mesa/program/prog_statevars.c | 11 +++ > src/mesa/program/prog_statevars.h | 2 + > 27 files changed, 382 insertions(+), 10 deletions(-) > create mode 100644 src/mapi/glapi/gen/ARB_sample_shading.xml _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
