On 12.09.2013 16:14, Roland Scheidegger wrote: > Am 12.09.2013 03:40, schrieb Dave Airlie: >>> Maybe the type isn't set correctly? Looks to me like these instructions >>> end up in mkCmp, which will set both src and dst type but ignore src >>> type and set both according to the same type (which was the dst type). >>> >>> Roland >> Okay I've attached my next attempt at fixing it, fixes the two testcases I >> had. > > No idea what setting type there really does but I guess that looks right > :-). Though I'm wondering if U32 vs. S32 would make a difference for dst > type since some of the (unsigned) comparisons still would use U32.
It doesn't make a difference, making it signed is unnecessary. If it helped before that was just because it made negative floats be interpreted as negative ints (instead of large ints) which has a slightly better chance of "succeeding". > Roland _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
