On 29 July 2013 11:17, Kenneth Graunke <kenn...@whitecape.org> wrote:
> On 07/28/2013 11:03 PM, Paul Berry wrote: > >> + >> + /** >> + * True if the implementation supports GLSL 1.50 style geometry >> shaders. >> + * This boolean is distinct from gl_extensions::ARB_geometry_**shader4 >> so >> + * that we can expose GLSL 1.50 (and GL 3.2) functionality without >> exposing >> + * {ARB,EXT}_geometry_shader4. >> + */ >> + GLboolean GeometryShaders150; >> }; >> > > I don't really like this new flag. In my mind, ctx->Const.GLSLVersion >= > 150 is sufficient, since I believe geometry shaders are required to expose > 1.50. > > ctx->Const.GLSLVersion is already used to compute the GL version. > > That's a good point. The GeometryShaders150 constant is really kind of weird, and it's hard to imagine a back-end wanting to expose GLSL 1.50 capability without geometry shaders. I'll fix this up.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev