On 07/25/2013 03:45 PM, Emil Velikov wrote:
Rather than having to keep track of all the build systems and their respecitve
definition of the mesa version, use a single top file VERSION. Every build
system is responsible for reading/parsing the file and using it
v2:
* remove useless bulletpoint from the documentation, suggested by Matt
* "Androing is Linux. Use '/' in stead of '\'", spotted by Chad V
* use cleaner code to get the version in scons, suggested by Chad V
v3:
* ensure leading and trailing whitespace characters are stripped while parsing
* android: handle GNU shell commands approapriately
Reviewed-by: Matt Turner <matts...@gmail.com>
Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com>
---
An interesting point while looking for ways to strip the newline character
- python considers carrage return as whitespace whereas m4 does not.
AFAICS no-one has used those nasty symbols in mesa, and I hope no-one will.
Just to be on the safe side I have tested editing the VERSION file with a
few different editors, adding multiple newlines at the end of the file.
SCons and Automake worked fine, whereas for Android I'm short of the build
system.
Cheers
Emil
Thanks Emil! This looks good to me. I'll give it a little time for
Chad/Matt to comment if they have more thoughts, but hopefully it can
land soon.
Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev