On 07/25/2013 12:39 PM, Emil Velikov wrote:
Rather than having to keep track of all the build systems and their respecitve
definition of the mesa version, use a single top file VERSION. Every build
system is responsible for reading/parsing the file and using it

v2:
* remove useless bulletpoint from the documentation, suggested by Matt
* "Androing is Linux. Use '/' in stead of '\'", spotted by Chad V
* use cleaner code to get the version in scons, suggested by Chad V

Reviewed-by: Matt Turner <matts...@gmail.com>
Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com>
---

Thanks for the tips and review guys.
Feel free to commit if it's ok now - lacking the access rights :\

Cheers
Emil

I like the idea of this patch, but there's one problem: autogen.sh dies with a really cryptic error if the VERSION file ends with a newline. My editor, at least, seems to want to append that automatically, so I assume others will run into that problem as well.

We could work around this by always doing:
$ echo -n '9.3.0-devel' > VERSION

but...I wonder if there's some way to make this more robust without complicating the code too badly.

--Ken
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to