On 11 July 2013 12:06, Matt Turner <matts...@gmail.com> wrote: > On Mon, Jul 8, 2013 at 10:40 AM, Paul Berry <stereotype...@gmail.com> > wrote: > > + const glsl_type *typ(const char *name) > > This must not be a typo, since it's consistent. >
Heh, "type" is a reserved word in so many languages that I guess I assumed it was reserved in C++ without even checking. Turns out it isn't. I'm doing a minor re-spin of this patch to address Ian's comments; I'll rename it to "type" in v2. > > The series is Reviewed-by: Matt Turner <matts...@gmail.com> > > with the caveat that the third patch is hard to review and I could > easily have missed something, since it's nearly a total rewrite. But > there's no question that the final result is better. Thanks for doing > this clean up. >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
