On 22 May 2013 12:21, Ian Romanick <i...@freedesktop.org> wrote:
> On 05/21/2013 04:52 PM, Paul Berry wrote:
>
>> diff --git a/src/mesa/drivers/dri/i915/i830_vtbl.c
>> b/src/mesa/drivers/dri/i915/i830_vtbl.c
>> index b30f45e..a35f58b 100644
>> --- a/src/mesa/drivers/dri/i915/**i830_vtbl.c
>> +++ b/src/mesa/drivers/dri/i915/**i830_vtbl.c
>> @@ -760,7 +760,13 @@ i830_update_draw_buffer(struct intel_context *intel)
>>
>> for (i = 0; i < fb->_NumColorDrawBuffers; i++) {
>> irb = intel_renderbuffer(fb->_**ColorDrawBuffers[i]);
>> - colorRegions[i] = (irb && irb->mt) ? irb->mt->region : NULL;
>> + if (irb && irb->mt) {
>> + colorRegions[i] =
>> + intel_miptree_get_region(**intel, irb->mt,
>> + INTEL_MIPTREE_ACCESS_RENDER);
>> + } else {
>> + colorRegions[i] = NULL;
>> + }
>>
>
> This idiom appears several places. Would it be better to pass irb and let
> intel_miptree_get_region return NULL? Or have a wrapper function? Just
> thinking out loud...
>
I'm not convinced it would be a benefit. But considering the discussion I
just had with Eric, Ken, and Chad (see my other reply with the same subject
line from a few minutes ago), the question is probably moot.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
