This series lives on my 'hiz-pre' branch. I have a large hiz series brewing for Haswell. To make review easier, I decided to post some preliminary patches first rather than posting the hiz patch bomb all at once. If you'd prefer that I shelve this series until I'm ready to submit the hiz series in its entirety, just let me know.
FYI, hiz hasn't been enabled on Haswell yet because some clumsiness in our driver hangs the GPU. Essentially, this patch series does two things: patches 1-7: Lays the groundwork so that we can selectively disable hiz for individual miptree images that hang the gpu. patches 8-12: In preparation for emitting 8x4 aligned rectangle primitives, add extra padding to hiz and depth miptrees. Refactors are sprinkled into this series. In some places, I found it necessary to clean up the code before I could sufficiently understand it to confidently make changes. No regressions against mesa-master-809fdc211, piglit-99055b7, Ivybridge 0x0126. Chad Versace (12): intel: Fix an instance of mixed tabs and spaces intel: Add field intel_mipmap_slice::has_hiz intel: Add accessor functions for intel_miptree_slice::has_hiz i965: Add level,layer members to brw_blorp_mip_info i965: Change signature of brw_get_depthstencil_tile_masks i965: Fix typo in doxygen hyperlink intel: Replace checks for hiz_mt with has_hiz accessors intel: Refactor selection of miptree tiling intel: Refactor selection of miptree's internal formats i965: Push stencil alignment w/a down to brw_miptree_layout() intel: Document intel_mipmap_tree::total_width,total_height i965: Add padding to depth and hiz miptrees src/mesa/drivers/dri/i965/brw_blorp.cpp | 4 +- src/mesa/drivers/dri/i965/brw_blorp.h | 10 ++ src/mesa/drivers/dri/i965/brw_clear.c | 2 +- src/mesa/drivers/dri/i965/brw_context.h | 10 ++ src/mesa/drivers/dri/i965/brw_draw.c | 2 +- src/mesa/drivers/dri/i965/brw_misc_state.c | 26 +++- src/mesa/drivers/dri/i965/brw_tex_layout.c | 25 ++++ src/mesa/drivers/dri/i965/gen6_blorp.cpp | 5 +- src/mesa/drivers/dri/i965/gen7_blorp.cpp | 5 +- src/mesa/drivers/dri/intel/intel_fbo.c | 7 + src/mesa/drivers/dri/intel/intel_fbo.h | 3 + src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 191 ++++++++++++++----------- src/mesa/drivers/dri/intel/intel_mipmap_tree.h | 24 +++- 13 files changed, 221 insertions(+), 93 deletions(-) -- 1.8.1.2 _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev