On 02/27/2013 04:58 PM, Eric Anholt wrote:
From: Paul Berry <stereotype...@gmail.com>

This bug is currently benign, since get_called_parameter_string() is
currently only used for functions that return true for
glx_function.has_different_protocol(), and none of those functions
include padding.  However, in order to implement marshalling of GL API
functions, we'll need to use get_called_parameter_string() far more
often.
---
  src/mapi/glapi/gen/gl_XML.py |    2 ++
  1 file changed, 2 insertions(+)

diff --git a/src/mapi/glapi/gen/gl_XML.py b/src/mapi/glapi/gen/gl_XML.py
index 227e9fc..3bbc794 100644
--- a/src/mapi/glapi/gen/gl_XML.py
+++ b/src/mapi/glapi/gen/gl_XML.py
@@ -802,6 +802,8 @@ class gl_function( gl_item ):
          comma = ""

          for p in self.parameterIterator():
+            if p.is_padding:
+                continue
              p_string = p_string + comma + p.name
              comma = ", "

Patches 1-3 are:
Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>

but need a proper prefix in the commit message (i.e. "mesa:")

I don't know how the counter mechanism works, so I don't feel qualified to review 4 and 5.

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to