Chris Forbes <chr...@ijw.co.nz> writes:

> On Gen6, lower this to `ld` with lod=0 and an extra sample_index
> parameter.
>
> On Gen7, use `ld2dms`. This takes an additional MCS parameter to support
> compressed multisample surfaces, but we're not enabling them for
> multisample textures for now, so it's always ignored and can be safely
> omitted.

For these fields you're relying on to be zero in these two patches, have
you tested with loading a nonzero value into that register?  We've had
problems with that a few times -- registers often start out at zero, so
tests don't catch that kind of bug.

If you do test that, then other than minor style nits in 18/19, patches
17-19 are Reviewed-by: Eric Anholt <e...@anholt.net>

Attachment: pgpgWAUMbD8K9.pgp
Description: PGP signature

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to