On Mon, Sep 10, 2012 at 4:46 PM, Anuj Phogat <anuj.pho...@gmail.com> wrote: > Brian, Did you get a chance to look at my other patch as well: > ([PATCH 2/2] _mesa_meta_GenerateMipmap: Generate > separate shaders for glsl 120 / 130) ? > Any more thoughts on including the code for 3D textures and > integer-textures ? I posted my views on this in an earlier > e-mail. I'll be happy to make any suggested changes in my > patches.
I replied to 2/2 with some minor issues. The last I saw from the ARB, it looks like GenerateMipmap will be illegal for integer textures (GL_INVALID_OPERATION). I'd suggest removing the integer support from your patch. It's OK to keep the 3D mipmap-gen code but make sure there's a comment(s) pointing out that it's not used yet. -Brian _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
