Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl> writes: > On Wed, Oct 6, 2021 at 8:49 PM Jordan Justen <jordan.l.jus...@intel.com> > wrote: >> >> I guess I missed where it was suggested that Marge should remove >> Reviewed-by tags. I don't think Marge should ever remove something from >> the commit message. > > AFAIU this is upstream Marge behavior. Once you enable the > Approval->Rb tag conversion it removes existing Rb tags. Hence why we > don't have the conversion enabled. >
Ah, I guess it is documented for --add-reviewers here: https://github.com/smarkets/marge-bot#adding-reviewed-by-tested-and-part-of-to-commit-messages "All existing Reviewed-by: trailers on commits in the branch will be stripped." I hope we would wait for Marge to add a --add-approvers switch which would leave Reviewed-by tags alone, but add Approved-by tags. -Jordan
