Hi Erik, The series looks very reasonable and I could not spot loosing any negating ! in the query logic. Even if I have not been able time wise to double checked every move when which texture format got introduced in which ES GL version. So, what can I tell now? Is that already a reviewed by?
What tests did you run on the series? May be I can convince myself to go forward using this testing information ... Well - and given the amount of discussion about #30, I mean #1-#29. best Mathias On Monday, 19 November 2018 13:15:05 CET Erik Faye-Lund wrote: > The OpenGL ES 3.0 specification, table 3.13 lists half-float textures as > filterable, but not float textures. So we shouldn't depend on > ARB_float_texture, which requires full filtering support for both. > > Signed-off-by: Erik Faye-Lund <erik.faye-l...@collabora.com> > --- > src/mesa/main/version.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c > index 210caad097e..fb5e816db32 100644 > --- a/src/mesa/main/version.c > +++ b/src/mesa/main/version.c > @@ -509,7 +509,9 @@ compute_version_es2(const struct gl_extensions > *extensions, > extensions->ARB_internalformat_query && > extensions->ARB_map_buffer_range && > extensions->ARB_shader_texture_lod && > - extensions->ARB_texture_float && > + extensions->OES_texture_float && > + extensions->OES_texture_half_float && > + extensions->OES_texture_half_float_linear && > extensions->ARB_texture_rg && > extensions->ARB_depth_buffer_float && > /* extensions->ARB_framebuffer_object && */ > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
