Just curious. Why is this change better? Why not just leave these as is
if it's not hurting anything?
On 20/11/18 6:24 pm, mathias.froehl...@gmx.net wrote:
From: Mathias Fröhlich <mathias.froehl...@web.de>
With the current VAO layout we do not need to make these
fields a bitfield. We get a tight struct layout with this change
for VAO attributes.
v2: Change unsigned char -> GLubyte.
Reviewed-by: Brian Paul <bri...@vmware.com>
Signed-off-by: Mathias Fröhlich <mathias.froehl...@web.de>
---
src/mesa/main/mtypes.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
index 62d3b75a36..157d45bc0b 100644
--- a/src/mesa/main/mtypes.h
+++ b/src/mesa/main/mtypes.h
@@ -1439,7 +1439,7 @@ struct gl_array_attributes
/** Stride as specified with gl*Pointer() */
GLshort Stride;
/** Index into gl_vertex_array_object::BufferBinding[] array */
- unsigned BufferBindingIndex:6;
+ GLubyte BufferBindingIndex;
/**
* Derived effective buffer binding index
@@ -1454,7 +1454,7 @@ struct gl_array_attributes
* Note that _mesa_update_vao_derived_arrays is called when binding
* the VAO to Array._DrawVAO.
*/
- unsigned _EffBufferBindingIndex:6;
+ GLubyte _EffBufferBindingIndex;
/**
* Derived effective relative offset.
*
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
