On Mon, 29 Oct 2018 at 11:46, Juan A. Suarez Romero <jasua...@igalia.com> wrote: > > On Tue, 2018-10-16 at 15:12 -0500, Jason Ekstrand wrote: > > This reverts commit 0fa9e6d7b304f6a8064ed78a4b9c557e1026e7e5. The real > > issue appears to have been that HiZ ops don't like having WM thread > > dispatch force-enabled. The previous commit fixes that problem so we > > can go back to using the ForceThreadDispatchEnable bit even on SKL+. > > --- > > src/intel/vulkan/genX_pipeline.c | 42 ++++++-------------------------- > > 1 file changed, 7 insertions(+), 35 deletions(-) > > > > > While this patch has landed in master with CC to @stable, I'm adding it to the > rejected list for 18.2, as the commit it reverts, 0fa9e6d7b30 ("anv/skylake: > disable ForceThreadDispatchEnable"), never landed in 18.2 branch. > > > The reason why 0fa9e6d7b30 didn't arrive to 18.2 was due an error in the fixes > tag. This commit fixes abd629eb3d4 "(anv: Stop setting > 3DSTATE_PS_EXTRA::PixelShaderHasUAV"), but instead we set in the Fixes: tag > 79270d2140ec "(anv: Stop setting 3DSTATE_PS_EXTRA::PixelShaderHasUAV"), which > is > actually a cherry-pick of the former. Hence that is why our scripts didn't > catch > it. > > In any case as 0fa9e6d7b30 ("anv/skylake: disable ForceThreadDispatchEnable") > is > not in 18.2, no need to revert it, so hence adding this patch to > cherry-ignore. > We can trivially extend get-extra-pick-list.sh (or add new one) which checks for reverts. Mistakes happen, which we can catch with some trivial tooling.
-Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev