On Friday, October 26, 2018 1:06:52 AM PDT andrey simiklit wrote: > Hi, > > Could you please help me with a push. I don't have a right for it :-) > > Thanks, > Andrii.
Thanks for fixing these up! While we're here, there are several other variables where we track the last known state of the GPU, which can go wrong if we roll back the commands that actually set that state: We may have rolled back a 3DSTATE_CONSTANT_* emit, so need to set brw->*.base.push_constants_dirty = true; We may have rolled back a 3DSTATE_URB_* emit, so need to set brw->urb.{vghd}size = something that won't match so we re-emit We may have rolled back 3DSTATE_DEPTH_BUFFER & friends, so we need to somehow deal with: brw->no_depth_or_stencil There may be more. Bonus points if you want to fix some of those up. :) Thanks again! --Ken
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev